Skip to content

experimental shipping of more CMake files for Enzyme #148027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

experimental shipping of more CMake files for Enzyme #148027

wants to merge 1 commit into from
+9 −1

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Oct 23, 2025 •
edited by Kobzol
Loading

For testing I just added the whole cmake folder for now, we might want to reduce it just to the LLVMconfig.cmake file later.
Based on some local comparisons between a x.py dist rust-dev folder structure and the ci-llvm folder structure (and where enzyme is looking) I think this should end up at the right location.

What would be the best way without merging to test that locally or in CI to verify that Enzyme now works? Or shall we just give it a try? Maybe

  1. Do a local x.py dist rust-dev build
  2. Build rust+enzyme with download-ci-llvm, wait till it fails.
  3. Delete the ci-llvm folder and replace it with the component from 1., which now includes the cmake files?

r? @Kobzol

try-job: dist-x86_64-linux

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 23, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 mentioned this pull request Oct 23, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member

Kobzol commented Oct 24, 2025

Could you please share some command that builds enzyme (plus config options) so that I can test it? The testing procedure that you suggested sounds reasonable.

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Oct 24, 2025

Thanks for handling the testing, here are instructions
https://rustc-dev-guide.rust-lang.org/autodiff/installation.html#build-instructions

@Kobzol
Copy link
Member

Kobzol commented Oct 24, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 24, 2025
@rust-bors
Auto merge of #148027 - ZuseZ4:dist-more-cmake, r=<try>
c730ece 
experimental shipping of more CMake files for Enzyme

try-job: dist-x86_64-linux
@rust-bors
Copy link

rust-bors bot commented Oct 24, 2025

☀️ Try build successful (CI)
Build commit: c730ece (c730eced8bb869eaf664af40b43ceb85f782d2d4, parent: 38bc2468dea062750e767bdd5c25f8279275baa0)

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Oct 24, 2025

I have not only added LLVMConfig.cmake, but also all other files in the same folder. However, it then starts to look for additional libraries, which is a much bigger ask than just including 2 (or 20) cmake files.

CMAKE_PREFIX_PATH
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.3")
-- Found zstd: /usr/lib/x86_64-linux-gnu/libzstd.so
CMake Error at /path/rust/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/cmake/llvm/LLVMExports.cmake:1743 (message):
  The imported target "LLVMDemangle" references the file

     "/path/rust/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/libLLVMDemangle.a"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/path/rust/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/cmake/llvm/LLVMExports.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /path/rust/rust/build/x86_64-unknown-linux-gnu/ci-llvm/lib/cmake/llvm/LLVMConfig.cmake:357 (include)
  CMakeLists.txt:74 (find_package)

@ZuseZ4 ZuseZ4 closed this Oct 24, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZuseZ4 @rust-log-analyzer @Kobzol @rustbot